Include null and undefined elements in flat() example #36095
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- I wasn't sure if `null`, `undefined`, and "empty" were equivalent in the eyes of the `flat()` method, so I tried it out in the console and learned that they are not. - I've modified the example for sparse arrays to include these values so that others don't have to run their own experiments to learn this information. - I also included a link to the sparse array documentation. If the way `flat()` handles `null` and `undefined` confuses the reader, I think they are likely to click on this link to educate themselves.
DanKaplanSES
requested review from
Josh-Cena
and removed request for
a team
github-actions
bot
added
Content:JS
|
Preview URLs (comment last updated: 2024-09-29 01:10:41) |
DanKaplanSES
changed the title
- I noticed that a later example uses the phrase "remove empty slots" in its language, otherwise I wouldn't have made this PR: - I think the "ignore" in "ignore empty slots" may be more technically correct, but "remove empty slots" paints a clearer picture and is harder to misinterpret. "Ignoring" an element could have meant it is returned without modification.
Josh-Cena
approved these changes
Sep 29, 2024
fiji-flo
pushed a commit
that referenced
this pull request
Oct 2, 2024
* Include null and undefined elements in flat() examples - I wasn't sure if `null`, `undefined`, and "empty" were equivalent in the eyes of the `flat()` method, so I tried it out in the console and learned that they are not. - I've modified the example for sparse arrays to include these values so that others don't have to run their own experiments to learn this information. - I also included a link to the sparse array documentation. If the way `flat()` handles `null` and `undefined` confuses the reader, I think they are likely to click on this link to educate themselves. * In flat() docs, change "ignore empty slots" to "remove empty slots" - I noticed that a later example uses the phrase "remove empty slots" in its language, otherwise I wouldn't have made this PR: - I think the "ignore" in "ignore empty slots" may be more technically correct, but "remove empty slots" paints a clearer picture and is harder to misinterpret. "Ignoring" an element could have meant it is returned without modification.
|
Great! Thank you very much |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Include null and undefined elements in flat() examples
Motivation
null,undefined, and "empty" were equivalent in the eyes of theflat()method, so I tried it out in the console and learned that they are not.flat()handlesnullandundefinedconfuses the reader, I think they are likely to click on this link to educate themselves.Additional details
Related issues and pull requests