Add HTMLMediaElement.addTextTrack() #36100
Conversation
github-actions
bot
added
Content:WebAPI
whoopsie daisies
There was a problem hiding this comment.
Hi @gusborg88! Thanks for your contribution. I have a few suggestions to make it follow MDN's latest guidelines and conventions.
|
Preview URLs (comment last updated: 2024-09-30 20:49:33) |
|
@gusborg88 Did you push your changes? |
|
It wont let me edit and keep the edits you made, so I'm just gonna wait until the MDN guy approves this PR with your changes, then make another PR. Or just leave it as is, the things you added fixed most issues anyway |
|
I'm not sure what you mean😅
For the ones I made suggestions, you can click "add suggestion to batch" and then commit all of them. For the ones I verbally suggested changes, you need to edit the file itself. Right now you just clicked "resolve conversation" without actually applying my suggestion. I didn't make edits; I just made suggestions.
Well I'm reviewing the PR, so once you apply my suggestions I will approve it. |
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
|
goddammit |
Co-authored-by: Joshua Chen <[email protected]>
Co-authored-by: Joshua Chen <[email protected]>
Co-authored-by: Joshua Chen <[email protected]>
Co-authored-by: Joshua Chen <[email protected]>
|
Should be good to merge now |
Co-authored-by: Joshua Chen <[email protected]>
Josh-Cena
changed the title
* made an addTextTrack() page * Forgot a right brace whoopsie daisies * Moved usage notes to intro * i did not add that I what the hell * the add to batch button wasnt working so im doing this Co-authored-by: Joshua Chen <[email protected]> * the add to batch button wasnt working so im doing this Co-authored-by: Joshua Chen <[email protected]> * the add to batch button wasnt working so im doing this Co-authored-by: Joshua Chen <[email protected]> * the add to batch button wasnt working so im doing this Co-authored-by: Joshua Chen <[email protected]> * Update files/en-us/web/api/htmlmediaelement/addtexttrack/index.md * Apply suggestions from code review Co-authored-by: Joshua Chen <[email protected]> * Fixed problem in example --------- Co-authored-by: Joshua Chen <[email protected]>
* made an addTextTrack() page * Forgot a right brace whoopsie daisies * Moved usage notes to intro * i did not add that I what the hell * the add to batch button wasnt working so im doing this Co-authored-by: Joshua Chen <[email protected]> * the add to batch button wasnt working so im doing this Co-authored-by: Joshua Chen <[email protected]> * the add to batch button wasnt working so im doing this Co-authored-by: Joshua Chen <[email protected]> * the add to batch button wasnt working so im doing this Co-authored-by: Joshua Chen <[email protected]> * Update files/en-us/web/api/htmlmediaelement/addtexttrack/index.md * Apply suggestions from code review Co-authored-by: Joshua Chen <[email protected]> * Fixed problem in example --------- Co-authored-by: Joshua Chen <[email protected]>
Description
I made a new page for HTMLMediaElement.addTextTrack(), I could't find what exceptions it throws though so that might need to be fixed.
Motivation
I'm working with this method right now, and I noticed MDN didn't have a page, so I made one.
Additional details
I found most of the info here: https://html.spec.whatwg.org/multipage/media.html#dom-media-addtexttrack
Related issues and pull requests