Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Experimental features: Fixes for cssletterspacing #37056

Merged
merged 10 commits into from
Dec 9, 2024

Conversation

hamishwillee
Copy link
Collaborator

@hamishwillee hamishwillee commented Dec 3, 2024

The experimental features page has a bunch of errors, reported in #36742. This fixes the following ones:

  • layout.css.letter-spacing.model is also enabled in developer - https://searchfox.org/mozilla-central/source/modules/libpref/init/StaticPrefList.yaml#9419
  • media.setsinkid.enabled - deleted the section. This was enabled in FF116 (and documented). Not enabled for android, but it isn't an experimental feature in android, it is just not implemented.
  • security.insecure_connection_text_* and browser.urlbar.trim preferences were enabled in nightly in FF121 https://bugzilla.mozilla.org/show_bug.cgi?id=1853418 - this updates the releases and also adds info about the browser.urlbar.trim preference ("somewhat related")
  • layout.css.relative-color-syntax.enabled - removed section as support added FF128 (and documented)
  • layout.css.font-tech.enabled - removed section - tech() feature added in 106
  • layout.css.backdrop-filter.enabled - CSS backdrop-filter - removed section as feature added in FF103
  • layout.css.page-orientation.enabled removed section page-orientation descriptor added in FF122
  • layout.css.zoom.enabled - removed section - CSS zoom added in FF126 (and documented)
  • layout.css.text-wrap-balance.enabled - remove section - stuff added in 121 (and documented 29787 text wrap browser-compat-data#21311)
  • layout.css.prefixes.transitions removes (supported in FF126). UPdated layout.css.prefixes.transforms as no longer supported in Nightly - test didn't work.
    ·

@github-actions github-actions bot added Content:Firefox Content in the Mozilla/Firefox subtree size/s [PR only] 6-50 LoC changed labels Dec 3, 2024
@hamishwillee hamishwillee force-pushed the ff_expr_feat_fix_cssletterspacing branch from dd6b444 to 4eae8e7 Compare December 3, 2024 02:29
@github-actions github-actions bot added size/xs [PR only] 0-5 LoC changed and removed size/s [PR only] 6-50 LoC changed labels Dec 3, 2024
Copy link
Contributor

github-actions bot commented Dec 3, 2024

Preview URLs

External URLs (3)

URL: /en-US/docs/Mozilla/Firefox/Experimental_features
Title: Experimental features in Firefox

(comment last updated: 2024-12-03 05:45:15)

@github-actions github-actions bot added size/s [PR only] 6-50 LoC changed and removed size/xs [PR only] 0-5 LoC changed labels Dec 3, 2024
@github-actions github-actions bot added size/m [PR only] 51-500 LoC changed and removed size/s [PR only] 6-50 LoC changed labels Dec 3, 2024
@hamishwillee hamishwillee marked this pull request as ready for review December 3, 2024 05:48
@hamishwillee hamishwillee requested a review from a team as a code owner December 3, 2024 05:48
@hamishwillee hamishwillee requested review from bsmth and removed request for a team December 3, 2024 05:48
### Vendor-prefixed transform properties

The `-moz-` prefixed [CSS transform](/en-US/docs/Web/CSS/CSS_transforms) properties have been disabled in the Nightly release via the `layout.css.prefixes.transforms` preference being set to `false`. ([Firefox bug 1855763](https://bugzil.la/1855763)).
Specifically, the disabled properties are:
The `-moz-` prefixed [CSS transform](/en-US/docs/Web/CSS/CSS_transforms) properties can be disabled by setting the `layout.css.prefixes.transforms` preference to `false`. The intent is to disable these once the standard CSS zoom properties are well supported. ([Firefox bug 1886134](https://bugzil.la/1886134), [Firefox bug 1855763](https://bugzil.la/1855763)).
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note, they tried to get this in in FF120, but when zoom when in in FF126 it broke too much. So this still exists, but it is off by default in nightly for the moment.

@hamishwillee
Copy link
Collaborator Author

hamishwillee commented Dec 3, 2024

@bsmth This should all be good, but you can get more info on the changes by cross referencing here #36742

@bsmth
Copy link
Member

bsmth commented Dec 3, 2024

@bsmth This should all be good, but you can get more info on the changes by cross referencing here #36742

Nicely done, thanks a lot. I'll take a look shortly

Copy link
Member

@bsmth bsmth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All looking good to me, maybe we can add something for page-orientation in a follow-up because the removal is correct here.

Thank you! 👍🏻

@hamishwillee
Copy link
Collaborator Author

maybe we can add something for page-orientation in a follow-up because the removal is correct here.

My take on release notes is that people are interested in the release month, but by the third month after release only weirdos like us care. I'll be updating anything in the last 6 releases, but no worth it after that.

I did however fix up BCD mdn/browser-compat-data#25299 because that has real and ongoing value.

@hamishwillee
Copy link
Collaborator Author

hamishwillee commented Dec 9, 2024

PS Thanks for the review. Nice to start the next lot with a clean slate. EDITED Except weirdly it wouldn't let me merge at first even with your approval - sorted on a second refresh. Crazy! Thanks again.

@hamishwillee hamishwillee requested a review from bsmth December 9, 2024 04:14
@hamishwillee hamishwillee merged commit 7baa0a6 into main Dec 9, 2024
9 checks passed
@hamishwillee hamishwillee deleted the ff_expr_feat_fix_cssletterspacing branch December 9, 2024 04:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Content:Firefox Content in the Mozilla/Firefox subtree size/m [PR only] 51-500 LoC changed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants