Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

@document: add link to userChrome.css #37143

Merged
merged 3 commits into from
Dec 11, 2024

Conversation

vitaly-zdanevich
Copy link
Contributor

Currently we have no page about userChrome.css, should it be created?

@vitaly-zdanevich vitaly-zdanevich requested a review from a team as a code owner December 9, 2024 05:29
@vitaly-zdanevich vitaly-zdanevich requested review from chrisdavidmills and removed request for a team December 9, 2024 05:29
@github-actions github-actions bot added Content:CSS Cascading Style Sheets docs size/xs [PR only] 0-5 LoC changed labels Dec 9, 2024
Copy link
Contributor

github-actions bot commented Dec 9, 2024

Preview URLs

External URLs (1)

URL: /en-US/docs/Web/CSS/@document
Title: @document

(comment last updated: 2024-12-11 07:22:28)

Copy link
Contributor

@chrisdavidmills chrisdavidmills left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @vitaly-zdanevich, and thanks for your contribution to MDN. I think it is useful to add a link to some more information as to what using a user-defined stylesheet might look like.

I have just got one suggestion — I think you could change the link text to userchrome.org, as that's what the website is actually called, plus I think you should link to the homepage, where the reader can find multiple articles to help them. In particular, I started reading the article you linked to and was thinking "but how do I use this? Where do I put userChrome.css??" and only found the link at the bottom of the article. If we just link to the homepage, you can see a link to both immediately, which I think is more useful.

Let me know what you think. Thanks again!

files/en-us/web/css/@document/index.md Outdated Show resolved Hide resolved
Copy link
Contributor

@chrisdavidmills chrisdavidmills left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks again @vitaly-zdanevich!

@chrisdavidmills chrisdavidmills merged commit a3fa3aa into mdn:main Dec 11, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Content:CSS Cascading Style Sheets docs size/xs [PR only] 0-5 LoC changed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants