Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(css): add nolint and increase output heights #37255

Merged
merged 1 commit into from
Dec 18, 2024
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 8 additions & 12 deletions files/en-us/web/html/element/summary/index.md
Original file line number Diff line number Diff line change
Expand Up @@ -77,7 +77,7 @@ You can use heading elements in `<summary>`, like this:

#### Result

{{EmbedLiveSample("Summaries_as_headings", 650, 120)}}
{{EmbedLiveSample("Summaries_as_headings", 650, 200)}}

This currently has some spacing issues that could be addressed using CSS.

Expand All @@ -101,7 +101,7 @@ This example adds some semantics to the `<summary>` element to indicate the labe

#### Result

{{EmbedLiveSample("HTML_in_summaries", 650, 120)}}
{{EmbedLiveSample("HTML_in_summaries", 650, 150)}}

### Changing the summary's icon

Expand Down Expand Up @@ -156,37 +156,33 @@ The CSS includes the `[open]` [attribute selector](/en-US/docs/Web/CSS/Attribute

#### HTML

```html
```html-nolint
<details>
<h1>Quotes from Helen Keller</h1>
<summary>On women's rights</summary>
<p>
<q
>We have prayed, we have coaxed, we have begged, for the vote, with the
<q>We have prayed, we have coaxed, we have begged, for the vote, with the
hope that men, out of chivalry, would bestow equal rights upon women and
take them into partnership in the affairs of the state. We hoped that
their common sense would triumph over prejudices and stupidity. We thought
their boasted sense of justice would overcome the errors that so often
fetter the human spirit; but we have always gone away empty-handed. We
shall beg no more.</q
>
shall beg no more.</q>
</p>
</details>

<details>
<summary>On optimism</summary>
<p>
<q
>Optimism is the faith that leads to achievement; nothing can be done
without hope.</q
>
<q>Optimism is the faith that leads to achievement; nothing can be done
without hope.</q>
</p>
</details>
```

#### Result

{{EmbedLiveSample("Changing the summary's icon", 650, 150)}}
{{EmbedLiveSample("Changing the summary's icon", 650, 400)}}

## Technical summary

Expand Down
Loading