enhance(telemetry): measure all external link clicks (#11981)

https://mozilla-hub.atlassian.net/browse/MP-1631
mdn · Oct 21, 2024 · 2a79c01 · 2a79c01
1 parent 8d51b73
commit 2a79c01
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 3 deletions.
diff --git a/client/src/telemetry/constants.ts b/client/src/telemetry/constants.ts
@@ -96,3 +96,5 @@ export const HOMEPAGE_ITEMS = Object.freeze({
   CONTRIBUTION: "contribution",
   CONTRIBUTION_REPO: "contribution_repo",
 });
+
+export const EXTERNAL_LINK = "external-link";
diff --git a/client/src/telemetry/glean-context.tsx b/client/src/telemetry/glean-context.tsx
@@ -15,7 +15,7 @@ import { useEffect, useRef } from "react";
 import { useLocation } from "react-router";
 import { useUserData } from "../user-context";
 import { handleSidebarClick } from "./sidebar-click";
-import { VIEWPORT_BREAKPOINTS } from "./constants";
+import { EXTERNAL_LINK, VIEWPORT_BREAKPOINTS } from "./constants";
 import { Doc } from "../../../libs/types/document";
 
 export type ViewportBreakpoint = "xs" | "sm" | "md" | "lg" | "xl" | "xxl";
@@ -174,8 +174,13 @@ function handleLinkClick(ev: MouseEvent, click: (source: string) => void) {
   if (anchor instanceof HTMLAnchorElement) {
     if (anchor.dataset.glean) {
       click(anchor.dataset.glean);
-    } else if (anchor.classList.contains("external")) {
-      click(`external-link: ${anchor.getAttribute("href") || ""}`);
+    }
+    if (
+      anchor.href &&
+      anchor.origin &&
+      anchor.origin !== document.location.origin
+    ) {
+      click(`${EXTERNAL_LINK}: ${anchor.href}`);
     }
   }
 }