Skip to content

Commit

Permalink
enhance(telemetry): enable Glean automatic page load events (#10985)
Browse files Browse the repository at this point in the history
chore(telemetry): remove unnecessary `max_events` option
fix(telemetry): allow live debugging

Removes the `max_events` option (we already default to 1 in recent versions). and changes the location of the logging enabled/disabled so that live debugging can happen without the logging being overwritten.

Co-authored-by: Alessio Placitelli <[email protected]>
  • Loading branch information
caugner and Dexterp37 authored Apr 24, 2024
1 parent 223fd3c commit 3b8e023
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions client/src/telemetry/glean-context.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -91,7 +91,7 @@ function glean(): GleanAnalytics {
const uploadEnabled = !userIsOptedOut && GLEAN_ENABLED;

Glean.initialize(GLEAN_APP_ID, uploadEnabled, {
maxEvents: 1,
enableAutoPageLoadEvents: true,
channel: GLEAN_CHANNEL,
migrateFromLegacyStorage: true,
serverEndpoint: DEV_MODE
Expand All @@ -101,8 +101,8 @@ function glean(): GleanAnalytics {

if (DEV_MODE) {
Glean.setDebugViewTag("mdn-dev");
Glean.setLogPings(GLEAN_DEBUG);
}
Glean.setLogPings(GLEAN_DEBUG);

const gleanContext = {
page: (page: PageProps) => {
Expand Down

0 comments on commit 3b8e023

Please sign in to comment.