review updates

mdn · Dec 5, 2024 · 79619cd · 79619cd
1 parent 9eeab20
commit 79619cd
Show file tree

Hide file tree

Showing 3 changed files with 8 additions and 10 deletions.
diff --git a/client/src/community/contributor-list.js b/client/src/community/contributor-list.js
@@ -2,12 +2,7 @@ import { LitElement, html } from "lit";
 
 import styles from "./contributor-list.scss?css" with { type: "css" };
 
-/**
- * @typedef {Object} ContributorData
- * @property {string} name
- * @property {string} github
- * @property {string} [org]
- */
+/** @import { ContributorData } from "./types" */
 
 export class ContributorList extends LitElement {
   static properties = {

diff --git a/client/src/community/types.d.ts b/client/src/community/types.d.ts
@@ -0,0 +1,5 @@
+export interface ContributorData {
+  name: string;
+  github: string;
+  org?: string;
+}
diff --git a/client/src/curriculum/scrim-inline.js b/client/src/curriculum/scrim-inline.js
@@ -143,10 +143,8 @@ class ScrimInline extends LitElement {
    * @param {MouseEvent} e
    */
   #toggle(e) {
-    if (e.target) {
-      /** @type {HTMLElement} */
-      (e.target).dataset.glean =
-        `${CURRICULUM}: scrim fullscreen -> ${this._fullscreen ? 0 : 1} id:${this._scrimId}`;
+    if (e.target instanceof HTMLElement) {
+      e.target.dataset.glean = `${CURRICULUM}: scrim fullscreen -> ${this._fullscreen ? 0 : 1} id:${this._scrimId}`;
     }
     if (this._fullscreen) {
       this.#close();