Skip to content

Commit

Permalink
fix(baseline): update icons, add text to feedback link
Browse files Browse the repository at this point in the history
also address review from prior PR:
#10128 (review)
- configure svgo to automatically remove height/width and add viewbox,
  and do so on baseline icons
- use classes instead of first/last-child for links
- don't show copy if low_date is undefined (it should always be defined
  if baseline is low/high, but just in case)
  • Loading branch information
LeoMcA committed Dec 12, 2023
1 parent ee298fb commit 7ae8589
Show file tree
Hide file tree
Showing 17 changed files with 40 additions and 26 deletions.
3 changes: 0 additions & 3 deletions client/config/webpack.config.js
Original file line number Diff line number Diff line change
Expand Up @@ -385,9 +385,6 @@ function config(webpackEnv) {
options: {
prettier: false,
svgo: false,
svgoConfig: {
plugins: [{ removeViewBox: false }],
},
titleProp: true,
ref: true,
},
Expand Down
2 changes: 1 addition & 1 deletion client/src/assets/icons/baseline/browser-check.svg
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
2 changes: 1 addition & 1 deletion client/src/assets/icons/baseline/browser-cross.svg
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
2 changes: 1 addition & 1 deletion client/src/assets/icons/baseline/chrome.svg
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
2 changes: 1 addition & 1 deletion client/src/assets/icons/baseline/edge.svg
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading

0 comments on commit 7ae8589

Please sign in to comment.