Skip to content

Commit

Permalink
fix(images): use dark text on white background (#9863)
Browse files Browse the repository at this point in the history
#9250 caused a regression by changing the 
background color of all images from white to the default background color, 
causing issues with images containing black elements on transparent background.

This reverts the image background color to white, but sets the text color to the 
default text color for the dark theme to resolve the original issue with alt texts.

Co-authored-by: Claas Augner <[email protected]>
  • Loading branch information
OnkarRuikar and caugner authored Oct 26, 2023
1 parent 0076cdd commit 90c868e
Showing 1 changed file with 4 additions and 1 deletion.
5 changes: 4 additions & 1 deletion client/src/document/index.scss
Original file line number Diff line number Diff line change
Expand Up @@ -83,9 +83,12 @@
}

img {
background: var(--background-primary);
/* In dark mode, required for images with black text on transparent background. */
background: #fff;
border: 1px solid var(--border-primary) !important;
border-radius: var(--elem-radius);
/* Required for alt texts. */
color: #1b1b1b;
display: inline-block;
display: flex;
height: auto;
Expand Down

0 comments on commit 90c868e

Please sign in to comment.