Apply suggestions from code review

Co-authored-by: Leo McArdle <[email protected]>
mdn · Sep 23, 2024 · ddeaf6d · ddeaf6d
1 parent 3f0fe62
commit ddeaf6d
Showing 1 changed file with 3 additions and 3 deletions.
diff --git a/client/src/ui/organisms/article-actions/language-menu/index.tsx b/client/src/ui/organisms/article-actions/language-menu/index.tsx
@@ -133,8 +133,8 @@ function LocaleRedirectSetting() {
   const [value, setValue] = useState(false);
 
   useEffect(() => {
-    setValue(!!getCookieValue(PREFERRED_LOCALE_COOKIE_NAME));
-  }, [setValue]);
+    setValue(Boolean(getCookieValue(PREFERRED_LOCALE_COOKIE_NAME)));
+  }, []);
 
   function toggle(event) {
     const newValue = event.target.checked;
@@ -147,7 +147,7 @@ function LocaleRedirectSetting() {
     } else {
       deleteCookie(PREFERRED_LOCALE_COOKIE_NAME);
     }
-    setValue(event.target.checked);
+    setValue(newValue);
     gleanClick(`${LANGUAGE_REDIRECT}: ${locale} -> ${Number(newValue)}`);
   }