Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(placement): switch to BSA #10011

Merged
merged 3 commits into from
Dec 1, 2023
Merged

chore(placement): switch to BSA #10011

merged 3 commits into from
Dec 1, 2023

Conversation

caugner
Copy link
Contributor

@caugner caugner commented Nov 13, 2023 •
edited
Loading

Summary

Switch to BSA for placements.

(MP-679)

@caugner caugner requested a review from a team as a code owner November 13, 2023 11:00
@caugner caugner marked this pull request as draft November 13, 2023 14:45
LeoMcA
LeoMcA reviewed Nov 13, 2023
View reviewed changes
cloud-function/README.md Outdated Show resolved Hide resolved
@caugner caugner force-pushed the switch-placements-to-bsa branch from e0ffedd to 72aff47 Compare November 29, 2023 15:09
@caugner caugner requested a review from LeoMcA November 29, 2023 15:11
@caugner caugner marked this pull request as ready for review November 29, 2023 15:14
LeoMcA
LeoMcA approved these changes Nov 29, 2023
View reviewed changes
Copy link
Member

@LeoMcA LeoMcA left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm aside from one missed BSA_URL_PREFIX reference
careful not to merge too soon :)

cloud-function/src/env.ts Outdated Show resolved Hide resolved
@caugner caugner merged commit ea98829 into main Dec 1, 2023
13 checks passed
@caugner caugner deleted the switch-placements-to-bsa branch December 1, 2023 11:47
@github-actions github-actions bot mentioned this pull request Dec 1, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LeoMcA LeoMcA LeoMcA approved these changes

Assignees
No one assigned
Labels
cloud-function github-actions
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@caugner @LeoMcA