Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(macros/LearnSidebar): add Games Developing section #10064

Merged
merged 2 commits into from
Nov 23, 2023

Conversation

pepelsbey
Copy link
Member

Summary

Features the Games section and a few articles in the Learn sidebar.

Fixes #8948

Problem

Low visibility of the Games section.

Solution

  • The title goes to the main game dev landing
  • There are three key articles under the toggler (debatable)

Screenshots

image

@pepelsbey pepelsbey requested a review from bsmth November 21, 2023 17:17
@pepelsbey pepelsbey requested a review from a team as a code owner November 21, 2023 17:17
@github-actions github-actions bot added the macros tracking issues related to kumascript macros label Nov 21, 2023
@caugner caugner changed the title Feature gamedev articles in the Learn sidebar chore(macros/LearnSidebar): add Games Developing section Nov 21, 2023
@pepelsbey pepelsbey added the involves: Content Requires the attention of the Content team. label Nov 21, 2023
@bsmth
Copy link
Member

bsmth commented Nov 22, 2023

This looks good to me. One other one looks interesting: https://developer.mozilla.org/en-US/docs/Games/Techniques do you think it's worth adding?

Comment on lines 645 to 652
link: "../Games",
subsections: [
{
name: "Guides_and_tutorials",
pages: [
"../Games/Introduction",
"../Games/Tutorials",
"../Games/Publishing_games",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@caugner do you know if there's a different way to handle relative paths like this, or is ../ okay to use here?

Copy link
Member Author

@pepelsbey pepelsbey Nov 22, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It was the only way I could get out of the Learn section. It works, but there might be a better way :)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess the best would be to move the Games section inside the Learn section, but otherwise I'm glad that the ../ syntax works. It makes it obvious that we're including pages from a different section.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

move the Games section inside the Learn section

That's a good idea. We should keep this in mind for Learn area refresh when we get to it.

@pepelsbey
Copy link
Member Author

pepelsbey commented Nov 22, 2023

One other one looks interesting … do you think it's worth adding?

A good one! Added.

@caugner caugner merged commit d4739d3 into mdn:main Nov 23, 2023
10 checks passed
@pepelsbey pepelsbey deleted the feature-gamedev branch November 23, 2023 13:31
@bsmth
Copy link
Member

bsmth commented Nov 23, 2023

Thanks, both! 🙌🏻

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
involves: Content Requires the attention of the Content team. macros tracking issues related to kumascript macros
Projects
None yet
Development

Successfully merging this pull request may close these issues.

No easy way to find Game Development section of MDN
3 participants