-
Notifications
You must be signed in to change notification settings - Fork 513
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(ai-help): Example header highlighting #10365
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* chore(macros/CSSRef): update zh-CN translation * fix previous 'margins, borders and padding'
github-actions
bot
added
dependencies
Pull requests that update a dependency file
macros
tracking issues related to kumascript macros
plus
work around features related to MDN Plus
deployer
Deployment (currently using AWS S3 and AWS Lambda)
plus:playground
plus:ai-help
labels
Jan 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
dependencies
Pull requests that update a dependency file
deployer
Deployment (currently using AWS S3 and AWS Lambda)
macros
tracking issues related to kumascript macros
plus:ai-help
plus:playground
plus
work around features related to MDN Plus
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This fixes an issue on example queues from either the AI help section or the blog section. In some situations, the mouse-over highlight of the example, triggered from the playground queue did not survive a scroll-into-view.
Problem
The highlight css attribute got set directly on the element from the mouse event handler. Therefore it did not survive a react re-render of the component. A render is sometimes triggered by the autmatic viewport scrolling.
Solution
Refactored the highlighting into a react state variable that is part of the UI context and properly tracked. The playground queue is currently used in the AI-help section and in the Blog section (to my knowledge).
How did you test this change?
Manually, locally