Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(stage-build): provide GH_TOKEN + specify repo in trigger job #10932

Merged
merged 2 commits into from
Apr 17, 2024

Conversation

caugner
Copy link
Contributor

@caugner caugner commented Apr 17, 2024

Summary

Follow-up of #10931 (MP-1055).

Problem

The new trigger job of the stage-build workflow fails, because it doesn't have the permission to gh workflow run and the call doesn't specify the repo.

Solution

  1. Reuse the @mdn-bot personal access token to trigger the workflow run.
  2. Specify the repo.

How did you test this change?

Temporarily changed the condition to run only the trigger on non-main branches, and it suceeded, triggering the actual build from next.

@caugner caugner requested a review from a team as a code owner April 17, 2024 09:18
@caugner caugner changed the title Fix stage build provide GitHub token fix(stage-build): provide GH_TOKEN + specify repo Apr 17, 2024
@caugner caugner changed the title fix(stage-build): provide GH_TOKEN + specify repo fix(stage-build): provide GH_TOKEN + specify repo in trigger job Apr 17, 2024
Copy link
Contributor Author

@caugner caugner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Self-approval.

@caugner caugner merged commit d371c0a into main Apr 17, 2024
12 checks passed
@caugner caugner deleted the fix-stage-build-provide-github-token branch April 17, 2024 09:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant