fix(callouts): reduce inner bottom spacing #10944
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We already add margins to all paragraphs, and this specific rule caused trailing margin in callouts (previously also in noteblocks, but this was overridden using !important).
This is no longer necessary, as the specific p:last-child rule is gone.
caugner
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Problem
Callouts had an unnecessary spacing after the last paragraph, because a specific CSS rule for
p:last-child { margin-bottom: 2rem; }rule was overriding thep { margin: none }rule for the callout. In fact, thatp:last-childrule is unnecessary, because we already definep { margin: 1rem 0 2rem; }more generally (which includesmargin-bottom: 2rem;).Solution
Remove the unnecessary CSS rule.
Note: At the same time, we can relax the
marginfor notecards, which was using the!importantflag to workaround the issue.Screenshots
How did you test this change?
Ran
yarn && yarn devlocally and looked at http://localhost:3000/en-US/docs/MDN/Writing_guidelines/Howto/Markdown_in_MDN#notes_warnings_and_callouts.