Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(macros/LearnSidebar): add Japanese translation for Cross browser testing, Git and GitHub, Server-side website programming, First steps, Django web framework (Python), Express Web Framework (Node.js/JavaScript) #10964

Merged
merged 1 commit into from
Apr 26, 2024

Conversation

gurezo
Copy link
Contributor

@gurezo gurezo commented Apr 20, 2024

Summary

@hmatrjp @potappo , mdn-yari-ja

please review for this pull request

Problem

still en-us only

Solution

translate japanese for LearnSidebar.ejs

NOTICE

@caugner, @wbamberg , @schalkneethling

Please merge once mdn-yari-ja is approved.

Before

still en-us only

After

add tranlate japanese for LearnSidebar.ejs

Copy link
Contributor

@potappo potappo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@gurezo
翻訳ありがとうございます。
元ページのタイトルがそうなっているからだと思うのですが、表記ガイドライン的には、「サーバー」、「ウェブ」にしたいです。元ページの表記も一緒に修正するのがベストですが、余裕がない場合、別途作業として issue を立てるでもかまいません。

@gurezo gurezo force-pushed the issues/isuue/757 branch from 558a4a0 to b8f7ccb Compare April 20, 2024 05:13
@gurezo
Copy link
Contributor Author

gurezo commented Apr 20, 2024

@gurezo 翻訳ありがとうございます。 元ページのタイトルがそうなっているからだと思うのですが、表記ガイドライン的には、「サーバー」、「ウェブ」にしたいです。元ページの表記も一緒に修正するのがベストですが、余裕がない場合、別途作業として issue を立てるでもかまいません。

@potappo 文言修正しました〜!

@gurezo gurezo requested a review from potappo April 20, 2024 05:15
@gurezo gurezo force-pushed the issues/isuue/757 branch from b8f7ccb to b6c2073 Compare April 20, 2024 05:18
@gurezo gurezo force-pushed the issues/isuue/757 branch from b6c2073 to f7bdec0 Compare April 20, 2024 05:20
@gurezo gurezo changed the title chore(macros/LearnSidebar): add Japanese translation for Cross browser testing, Server-side website programming, First steps chore(macros/LearnSidebar): add Japanese translation for Cross browser testing, Git and GitHub, Server-side website programming, First steps, Django web framework (Python), Express Web Framework (Node.js/JavaScript) Apr 20, 2024
Copy link
Contributor

@potappo potappo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gurezo
Copy link
Contributor Author

gurezo commented Apr 20, 2024

@caugner, @wbamberg , @schalkneethling

alreday appoved by mdn-yari-ja (@potappo )
please this PR review

@caugner caugner merged commit aa0224f into mdn:main Apr 26, 2024
10 checks passed
@gurezo gurezo deleted the issues/isuue/757 branch September 21, 2024 05:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
macros tracking issues related to kumascript macros
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants