-
Notifications
You must be signed in to change notification settings - Fork 512
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(css): remove screen condition from media queries #11142
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
plus
work around features related to MDN Plus
placement
blog
plus:playground
plus:ai-help
labels
May 16, 2024
pepelsbey
added
enhancement
Improves an existing feature.
and removed
plus
work around features related to MDN Plus
placement
plus:playground
plus:ai-help
blog
labels
May 16, 2024
github-actions
bot
added
plus
work around features related to MDN Plus
placement
blog
plus:playground
plus:ai-help
labels
May 20, 2024
github-actions
bot
added
dependencies
Pull requests that update a dependency file
deployer
Deployment (currently using AWS S3 and AWS Lambda)
cloud-function
labels
May 23, 2024
pepelsbey
removed
dependencies
Pull requests that update a dependency file
plus
work around features related to MDN Plus
deployer
Deployment (currently using AWS S3 and AWS Lambda)
placement
cloud-function
labels
May 23, 2024
github-actions
bot
added
plus
work around features related to MDN Plus
placement
blog
plus:playground
plus:ai-help
labels
May 23, 2024
pepelsbey
removed
plus
work around features related to MDN Plus
placement
blog
plus:playground
plus:ai-help
labels
May 23, 2024
github-actions
bot
added
plus
work around features related to MDN Plus
placement
blog
plus:playground
plus:ai-help
labels
Jun 5, 2024
caugner
changed the title
fix(css): remove
fix(css): remove screen condition from media queries
Jun 5, 2024
screen and
from MQ
caugner
approved these changes
Jun 5, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. There's a small chance that this has an impact on the print layout, but the effect of those conditions on the print layout is most likely not intended in the first place.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
blog
enhancement
Improves an existing feature.
placement
plus:ai-help
plus:playground
plus
work around features related to MDN Plus
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
It removes parts of
@media
conditions we don’t actually use:Problem
Right now
@media screen and (…)
conditions@media (…)
conditionsIt seems like we don’t write CSS exclusively for
screen
but rather forall
:Since there’s no
media="screen"
on that element, all our styles outside of@media
have implicit mediaall
, but the ones inside@media
arescreen
only for some reason.The only effect
@media screen and (…)
has right now is that these adaptive styles don’t apply for printing. It doesn’t seem intentional. For printing, we use inlined<style media="print">
that overrides styles forall
andscreen
the same way.Solution
Remove unused parts of
@media
conditions.How did you test this change?
I ran it locally and couldn’t find any difference.