enhance(cloud-function): return 404.json if index.json not found #11442
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LeoMcA
reviewed
Jul 9, 2024
caugner
commented
Jul 10, 2024
Comment on lines
+13
to
+16
| const NOT_FOUND_JSON = "en-us/_spas/404.json"; | ||
| const NOT_FOUND_HTML = "en-us/_spas/404.html"; | ||
|
|
||
| let notFoundBuffer: ArrayBuffer; | ||
| const bufferCache = new Map<string, ArrayBuffer>(); |
There was a problem hiding this comment.
This prepares for having per-locale 404 pages, as currently the 404 page only has en-US links in the top navigation.
|
This pull request has merge conflicts that must be resolved before it can be merged. |
github-actions
bot
added
the
merge conflicts 🚧
|
Superseded by #12248. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
(MP-1356)
Problem
We usually show a nice 404 page (e.g. https://developer.allizom.org/en-US/404), but this does not apply for Blog (https://developer.allizom.org/en-US/blog/404/) and Curriculum (https://developer.allizom.org/en-US/curriculum/404/). The correct 404 page shows up shortly, and is then replaced by an empty page with only header and footer.
Solution
Return
404.jsonfor missingindex.jsonrequests.Screenshots
Before
After
How did you test this change?
Will deploy to stage on July 10.