Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DNM: test what impact on bundle size adding deterministic ids has #11772

Closed
wants to merge 2 commits into from
+6 −2
Closed

DNM: test what impact on bundle size adding deterministic ids has #11772

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
06b7c25
fix(bundle-size): partially revert 4a5cf81b8958bb3b5f80b8d20ae0bc1ae1…
LeoMcA Sep 9, 2024
d718778
fix(bundle-size): increase deterministic id to 4 chars
LeoMcA Sep 9, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions client/config/webpack.config.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -162,8 +162,8 @@ function config(webpackEnv) {
level: "none",
},
optimization: {
chunkIds: isEnvProduction ? "natural" : "named",
moduleIds: isEnvProduction ? "natural" : "named",
chunkIds: isEnvProduction ? false : "named",
moduleIds: isEnvProduction ? "deterministic" : "named",
minimize: isEnvProduction,
minimizer: [
// This is only used in production mode
Expand Down Expand Up @@ -519,6 +519,10 @@ function config(webpackEnv) {
analyzerMode: "disabled",
generateStatsFile: true,
}),
isEnvProduction &&
new webpack.ids.DeterministicChunkIdsPlugin({
maxLength: 4, // this is actually min length
}),
].filter(Boolean),
// Turn off performance processing because we utilize
// our own hints via the FileSizeReporter
Expand Down
Loading