feat(curriculum): add scrim-inline custom element #11823
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
use on curriculum homepage within react also update the design a little bit
github-actions
bot
added
dependencies
fiji-flo
approved these changes
Sep 17, 2024
client/src/curriculum/landing.tsx
Outdated
| <ScrimIframe url={SCRIM_URL}> | ||
| <section className="scrim-wrapper"> | ||
| <div className="scrim-border"> | ||
| <Suspense fallback={<scrim-inline />}> |
There was a problem hiding this comment.
if threre's an easy way we could wrap ScrimInline programmatically in scrim-inline.ts
There was a problem hiding this comment.
It's a little bit of a chicken and egg problem in that we need to load scrim-inline.ts async in order for it to not bloat our bundle size, but the Suspense stuff all needs to be loaded sync for it to actually work: so the helper function would need to live in another file. If this becomes a common pattern for us, I think we can do that then.
Bundle StatsHey there, this message comes from a github action that helps you and reviewers to understand how these changes affect the size of this project's bundle. As this PR is updated, I'll keep you updated on how the bundle size is impacted. Total
View detailed bundle breakdownAdded
Removed
Bigger No assets were bigger Smaller No assets were smaller Unchanged
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
https://mozilla-hub.atlassian.net/browse/MP-1475
Problem
Solution
Re-implement the scrim react component as a lit component, and update the background.
There are a number of things here which I've deliberately de-scoped:
css``template literals here don't run through webpack, they don't use SCSS, they have to be written inline, they aren't linted - there's a number of conveniences/optimisations we could add, but I think it's best to wait until we have a bit of experience with how Lit "feels" before we invest time into these thingshtml``literals, etc: similarly, let's get a feel for Lit before we invest in tooling surrounding itScreenshots
Before
After
How did you test this change?