Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(css): set border color on home page search input field #11931

Merged
merged 3 commits into from
Dec 9, 2024

Conversation

jazzygasper
Copy link
Contributor

@jazzygasper jazzygasper commented Oct 8, 2024

Summary

Fixes #11276

Problem

The search input field on the homepage was not very visible on mobile Safari because of a missing border color.

Solution

The search input field was using the default browser style for the border, which were inconsistent across browsers. I added a specific border color to the search input field to ensure consistent visibility, especially in mobile Safari.


Screenshots

Before

IMG_0464

After

IMG_0463


How did you test this change?

Tested on safari mobile (iphone), safari desktop, chrome desktop and firefox desktop.

@jazzygasper jazzygasper requested a review from a team as a code owner October 8, 2024 23:59
@jazzygasper jazzygasper force-pushed the 11276-search-field-border branch from 3a8f94d to c91a888 Compare October 9, 2024 00:35
@jazzygasper jazzygasper force-pushed the 11276-search-field-border branch from c91a888 to d57cadc Compare October 9, 2024 00:46
@github-actions github-actions bot added the idle label Nov 8, 2024
@argl argl changed the title fix: add border color on search input field fix(css): set border color on home page search input field Dec 6, 2024
@argl
Copy link
Contributor

argl commented Dec 6, 2024

Thanks for reporting! I have pushed the change to our staging environment to be able to push it through our QA pipeline and make double-shure that it does not have any ill side effects.

@github-actions github-actions bot removed the idle label Dec 7, 2024
Copy link
Contributor

@argl argl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, many thanks for noticing and fixing it!

@argl argl enabled auto-merge (squash) December 9, 2024 12:06
@argl argl merged commit c2dc988 into mdn:main Dec 9, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Search field is barely visible in mobile Safari
2 participants