fix(search-index): use en-US popularities for German #12212
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bundle StatsHey there, this message comes from a github action that helps you and reviewers to understand how these changes affect the size of this project's bundle. As this PR is updated, I'll keep you updated on how the bundle size is impacted. Total
View detailed bundle breakdownAdded
Removed
Bigger No assets were bigger Smaller
Unchanged
|
caugner
added a commit
to mdn/rari
that referenced
this pull request
Nov 29, 2024
|
Can we solve this like this for now? (Note: This won't fix it for the local experience but that's fine. |
The search index contains the page titles, so unfortunately this is not an acceptable solution from a UX perspective, because it would mean the German quick search shows English page titles. |
|
This pull request has merge conflicts that must be resolved before it can be merged. |
github-actions
bot
added
github-actions
merge conflicts 🚧
github-actions
bot
removed
the
merge conflicts 🚧
fiji-flo
approved these changes
Dec 4, 2024
caugner
force-pushed
the
MP-1779-use-en-us-popularities-for-de
branch
from
4d56fa3 to
5583e87
Compare
Good idea, fixed in 5583e87. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
(MP-1779)
Ported to rari in mdn/rari#53.
Problem
The German quick search does not show results in a very useful order, because it is based on page views in the previous month, and the German locale did not have any page views in the last month (October).
Solution
Use the page views fromen-USinstead.Use the
en-USsearch index to reorder thedeindex at deployment time (as per @fiji-flo's request).Screenshots
How did you test this change?
Ranyarn && yarn devwithCONTENT_TRANSLATED_ROOTpointing to../translated-content-de/filesand viewed http://localhost:3000/de/, comparing it to https://developer.mozilla.org/de/.searchin en-US and de.