fix(cloud-function): add libs/play as dependency #12291
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bundle StatsHey there, this message comes from a github action that helps you and reviewers to understand how these changes affect the size of this project's bundle. As this PR is updated, I'll keep you updated on how the bundle size is impacted. Total
View detailed bundle breakdownAdded No assets were added Removed No assets were removed Bigger No assets were bigger Smaller No assets were smaller Unchanged
|
LeoMcA
changed the title
caugner
reviewed
Dec 11, 2024
.github/workflows/testing.yml
Outdated
Comment on lines
35
to
37
| - name: Install all npm packages (libs/play) | ||
| working-directory: libs/play | ||
| run: npm ci |
There was a problem hiding this comment.
Why is this necessary, given that yarn install should also run npm install there via the prepare script?
Lines 35 to 40 in f194598
There was a problem hiding this comment.
Ah right, it was an ordering issue: the install happened in cloud-function first, before play, and so play was copied sans node_modules: adding @yari-internal/play as a dep in cloud-function seems to hoist its dependencies into cloud-function's lockfile, avoiding that problem
caugner
approved these changes
Dec 11, 2024
LeoMcA
changed the title
LeoMcA
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Problem
Our lint job is failing: https://github.com/mdn/yari/actions/runs/12275409047/job/34250396498
Solution
Install the missing dependencies
How did you test this change?
In this PR: the lint job succeeds!