Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enhance(blog): optimize performance with concurrent async execution #9663

Closed

Conversation

sanjaiyan-dev
Copy link

Hi, this PR makes a small performance improvement by running async functions concurrently, using Promise.all.

Extremely sorry if I made any mistakes :(

@github-actions github-actions bot added the macros tracking issues related to kumascript macros label Sep 14, 2023
@caugner caugner requested a review from LeoMcA September 18, 2023 13:50
@caugner caugner changed the title Optimizing Performance with Concurrent Async Execution 🚗 enhance(blog): optimize performance with concurrent async execution Sep 18, 2023
@caugner caugner requested a review from a team as a code owner November 7, 2023 20:09
@sanjaiyan-dev
Copy link
Author

👀

@github-actions github-actions bot added the idle label Jan 24, 2024
Copy link
Contributor

@caugner caugner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We (@argl @fiji-flo @caugner) took a look and appreciate your suggestions, but decided to reject the change, because it adds complexity for minimal performance gain.

Thanks again for taking the time to open this PR! 🙏

@caugner caugner closed this Mar 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
idle macros tracking issues related to kumascript macros
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants