chore(footer): add Mastodon link #9689
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shuuji3
force-pushed
the
footer/add-mastodon-link
branch
from
b1f773f to
bbaa69c
Compare
|
I've updated it to include both social icon links on the footer. And I confirmed both links are working as expected on the local dev server.
|
3 tasks
caugner
requested changes
Oct 31, 2023
|
Here are the latest screenshots. Large screen
Mobile screen
|
caugner
changed the title
caugner
changed the title
|
Thank you! 🙂 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #9688
Problem
Recently, MDN launched the official Mastodon account https://mozilla.social/@MDN/111047293974029651 at mozilla.social (thanks for using Elk!). However, although I can see the link from https://github.com/mdn page, there is no Mastodon icon link on the MDN website. Discoverability is important for the Mastodon account.
Solution
This PR replaces the Twitter icon link with the newly created Mastodon icon link.
But I'm not sure this is an appropriate change yet. Please see the comment on the original issue.
Screenshots
Before
After
How did you test this change?