Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps): bump react-markdown from 8.0.7 to 9.0.0 #9739

Closed

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Sep 28, 2023

Bumps react-markdown from 8.0.7 to 9.0.0.

Release notes

Sourced from react-markdown's releases.

9.0.0

Change

  • b67d714 Change to require Node.js 16 migrate: update too
  • ec2b134 Change to require React 18 migrate: update too
  • bf5824f Change to use exports migrate: don’t use private APIs
  • c383a45 Update @types/hast, utilities, plugins, etc migrate: update too
  • eca5e6b 08ead9e Replace transformImageUri, transformLinkUri w/ urlTransform migrate: see Add urlTransform
  • de29396 Remove linkTarget option by @​galabra in remarkjs/react-markdown#762 migrate: see Remove linkTarget
  • 4346276 Remove support for passing custom props to components migrate: see Remove includeElementIndex, Remove rawSourcePos, Remove sourcePos, Remove extra props passed to certain components
  • c0dfbd6 Remove UMD bundle from package migrate: use esm.sh or a CDN or so
  • e12b5e9 Remove prop-types migrate: use TypeScript
  • 4eb7aa0 Change to throw errors for removed props migrate: don’t pass options that don’t do things
  • 8aabf74 Change to improve error messages migrate: expect better messages

Full Changelog: remarkjs/react-markdown@8.0.7...9.0.0

Changelog

Sourced from react-markdown's changelog.

9.0.0 - 2023-09-27

  • b67d714 Change to require Node.js 16
    migrate: update too
  • ec2b134 Change to require React 18
    migrate: update too
  • bf5824f Change to use exports
    migrate: don’t use private APIs
  • c383a45 Update @types/hast, utilities, plugins, etc
    migrate: update too
  • eca5e6b 08ead9e Replace transformImageUri, transformLinkUri w/ urlTransform
    migrate: see “Add urlTransform” below
  • de29396 Remove linkTarget option
    migrate: see “Remove linkTarget” below
  • 4346276 Remove support for passing custom props to components
    migrate: see “Remove includeElementIndex”, “Remove rawSourcePos”, “Remove sourcePos”, “Remove extra props passed to certain components” below
  • c0dfbd6 Remove UMD bundle from package
    migrate: use esm.sh or a CDN or so
  • e12b5e9 Remove prop-types
    migrate: use TypeScript
  • 4eb7aa0 Change to throw errors for removed props
    migrate: don’t pass options that don’t do things
  • 8aabf74 Change to improve error messages
    migrate: expect better messages

Add urlTransform

The transformImageUri and transformLinkUri were removed. Having two functions is a bit much, particularly because there are more URLs you might want to change (or which might be unsafe so we make them safe). And their name and APIs were a bit weird. You can use the new urlTransform prop instead to change all your URLs.

Remove linkTarget

The linkTarget option was removed; you should likely not set targets.

... (truncated)

Commits
  • 6360bc2 9.0.0
  • 72e68d2 Add docs on line endings
  • b67d714 Change to require Node.js 16
  • bf5824f Change to use exports
  • d056940 Refactor docs
  • 08ead9e Refactor to improve safe URL detection
  • a1fc6d9 Refactor package.json some more
  • eca5e6b Replace transformImageUri, transformLinkUri w/ urlTransform
  • ec2b134 Change to require React 18
  • c0dfbd6 Remove UMD bundle from package
  • Additional commits viewable in compare view

Dependabot compatibility score

You can trigger a rebase of this PR by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore <dependency name> major version will close this group update PR and stop Dependabot creating any more for the specific dependency's major version (unless you unignore this specific dependency's major version or upgrade to it yourself)
  • @dependabot ignore <dependency name> minor version will close this group update PR and stop Dependabot creating any more for the specific dependency's minor version (unless you unignore this specific dependency's minor version or upgrade to it yourself)
  • @dependabot ignore <dependency name> will close this group update PR and stop Dependabot creating any more for the specific dependency (unless you unignore this specific dependency or upgrade to it yourself)
  • @dependabot unignore <dependency name> will remove all of the ignore conditions of the specified dependency
  • @dependabot unignore <dependency name> <ignore condition> will remove the ignore condition of the specified dependency and ignore conditions

Note
Automatic rebases have been disabled on this pull request as it has been open for over 30 days.

@dependabot dependabot bot added dependencies Pull requests that update a dependency file javascript Pull requests that update Javascript code labels Sep 28, 2023
@github-actions github-actions bot added the merge conflicts 🚧 Please rebase onto or merge the latest main. label Oct 2, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Oct 2, 2023

This pull request has merge conflicts that must be resolved before it can be merged.

@dependabot dependabot bot force-pushed the dependabot/npm_and_yarn/react-markdown-9.0.0 branch from 13abed6 to 23bf8c4 Compare October 2, 2023 11:57
@github-actions github-actions bot removed the merge conflicts 🚧 Please rebase onto or merge the latest main. label Oct 2, 2023
@dependabot dependabot bot force-pushed the dependabot/npm_and_yarn/react-markdown-9.0.0 branch from 23bf8c4 to 4aa72a2 Compare October 16, 2023 11:40
@github-actions github-actions bot added the merge conflicts 🚧 Please rebase onto or merge the latest main. label Oct 23, 2023
@github-actions
Copy link
Contributor

This pull request has merge conflicts that must be resolved before it can be merged.

@dependabot dependabot bot force-pushed the dependabot/npm_and_yarn/react-markdown-9.0.0 branch from 4aa72a2 to 2e9125b Compare October 23, 2023 12:19
@github-actions github-actions bot removed the merge conflicts 🚧 Please rebase onto or merge the latest main. label Oct 23, 2023
@dependabot dependabot bot force-pushed the dependabot/npm_and_yarn/react-markdown-9.0.0 branch from 2e9125b to af23314 Compare October 24, 2023 15:10
@github-actions github-actions bot added merge conflicts 🚧 Please rebase onto or merge the latest main. labels Nov 7, 2023
Copy link
Contributor

github-actions bot commented Nov 7, 2023

This pull request has merge conflicts that must be resolved before it can be merged.

1 similar comment
Copy link
Contributor

github-actions bot commented Nov 7, 2023

This pull request has merge conflicts that must be resolved before it can be merged.

@caugner
Copy link
Contributor

caugner commented Nov 7, 2023

@dependabot rebase

Bumps [react-markdown](https://github.com/remarkjs/react-markdown) from 8.0.7 to 9.0.0.
- [Release notes](https://github.com/remarkjs/react-markdown/releases)
- [Changelog](https://github.com/remarkjs/react-markdown/blob/main/changelog.md)
- [Commits](remarkjs/react-markdown@8.0.7...9.0.0)

---
updated-dependencies:
- dependency-name: react-markdown
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <[email protected]>
@dependabot dependabot bot force-pushed the dependabot/npm_and_yarn/react-markdown-9.0.0 branch from af23314 to 933c39b Compare November 7, 2023 16:15
@dependabot dependabot bot requested a review from mdn-bot as a code owner November 7, 2023 16:15
@github-actions github-actions bot removed the merge conflicts 🚧 Please rebase onto or merge the latest main. label Nov 7, 2023
@caugner
Copy link
Contributor

caugner commented Nov 7, 2023

@fiji-flo Heads up that we're affected by a breaking change in react-markdovn v9:

(From here:)

Remove extra props passed to certain components

When overwriting components, these props are no longer passed:

  • inline on code:
    — create a plugin or use pre for the block

code: ({ inline, className, children, ...props }) => {
const match = /language-(\w+)/.exec(
className || ""
);
const lang = Prism.languages[match?.[1]];
return !inline && lang ? (

You added that code handler in #9510, can you share where inline comes from?

edit: Okay, I believe the path forward is to merge the code handler into the pre handler.

@github-actions github-actions bot added the merge conflicts 🚧 Please rebase onto or merge the latest main. label Nov 8, 2023
Copy link
Contributor

github-actions bot commented Nov 8, 2023

This pull request has merge conflicts that must be resolved before it can be merged.

@github-actions github-actions bot removed the merge conflicts 🚧 Please rebase onto or merge the latest main. label Nov 10, 2023
Copy link
Contributor Author

dependabot bot commented on behalf of github Nov 14, 2023

Superseded by #10024.

@dependabot dependabot bot closed this Nov 14, 2023
@dependabot dependabot bot deleted the dependabot/npm_and_yarn/react-markdown-9.0.0 branch November 14, 2023 11:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file javascript Pull requests that update Javascript code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant