Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(search): add more special character mappings #9748

Draft
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

caugner
Copy link
Contributor

@caugner caugner commented Sep 29, 2023

Summary

Ref #8921 #9749

Problem

The full-text search silently drops certain special characters, preventing users from searching for <!-- or ${.

Solution

Map more known special character compositions using unicorns_char_filter.


Screenshots

Before

After


How did you test this change?

TBD by running a stage deploy.

@github-actions github-actions bot added python Pull requests that update Python code deployer Deployment (currently using AWS S3 and AWS Lambda) labels Sep 29, 2023
@caugner caugner temporarily deployed to stage September 29, 2023 15:29 — with GitHub Actions Inactive
@caugner caugner temporarily deployed to stage September 29, 2023 21:45 — with GitHub Actions Inactive
@github-actions github-actions bot added the idle label Jan 24, 2024
@github-actions github-actions bot removed the idle label Mar 30, 2024
@github-actions github-actions bot added the idle label Apr 29, 2024
@caugner caugner force-pushed the search-add-char-mappings branch from a565dd6 to 5a34d0e Compare May 20, 2024 14:54
@github-actions github-actions bot removed the idle label May 20, 2024
@github-actions github-actions bot added the idle label Jun 20, 2024
@github-actions github-actions bot removed the idle label Aug 16, 2024
@github-actions github-actions bot added the idle label Sep 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
deployer Deployment (currently using AWS S3 and AWS Lambda) idle python Pull requests that update Python code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant