enhance(macros/APIRef): show badges on all links #9757
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
caugner
changed the title
caugner
commented
Feb 29, 2024
caugner
commented
Feb 29, 2024
caugner
force-pushed
the
APIRef-show-badges-on-all-links
branch
from
35748bd to
55971dd
Compare
github-actions
bot
added
the
merge conflicts 🚧
|
This pull request has merge conflicts that must be resolved before it can be merged. |
github-actions
bot
removed
the
merge conflicts 🚧
caugner
commented
May 2, 2024
|
Thanks very much @caugner !! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #9430.
Problem
The APIRef macros was showing badges (e.g. deprecated) only on some links.
Solution
Add badges to the remaining links.
Screenshots
How did you test this change?
Ran
yarn && yarn devand opened http://localhost:3000/en-US/docs/Web/API/DOMException and http://localhost:3000/en-US/docs/Web/API/DOMError locally.