Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(redirects): remove broken redirect rules #9762

Merged
merged 3 commits into from
Oct 8, 2023

Conversation

yin1999
Copy link
Member

@yin1999 yin1999 commented Oct 3, 2023

Summary

Fixes: #9664

Problem

We have removed all the assets hosted on mdn.mozillademos.org, so those rules are broken now.

Solution

Remove those rules.


How did you test this change?

Haven't tested this.

@github-actions github-actions bot added the python Pull requests that update Python code label Oct 3, 2023
Copy link
Contributor

@caugner caugner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just one nit: Let's also remove the corresponding header comment.

libs/fundamental-redirects/index.js Outdated Show resolved Hide resolved
@yin1999 yin1999 requested a review from caugner October 7, 2023 01:19
@caugner caugner merged commit ad64ce5 into mdn:main Oct 8, 2023
9 checks passed
@yin1999 yin1999 deleted the remove-broken-rules branch October 8, 2023 06:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
python Pull requests that update Python code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Broken redirect rules in fundamental-redirects
2 participants