Pong2 #9775
Merged
Pong2 #9775
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
this refactors the pong lib: - bundle click.js, get.js, viewed.js in pong.js - add pong2.js based on bsa's api - remove fallback
fiji-flo
commented
Oct 9, 2023
| }; | ||
|
|
||
| export default function anonymousIpByCC(countryCode) { | ||
| return cc2ip[countryCode] ?? "127.0.0.1"; | ||
| return cc2ip[countryCode] ?? "10.10.10.10"; |
There was a problem hiding this comment.
IPs and fallback was provided by BSA.
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| @@ -37,8 +37,8 @@ | |||
| proxyApi | |||
| ); | |||
| router.all("/submit/mdn-yari/*", requireOrigin(Origin.main), proxyTelemetry); | |||
| router.all("/pong/*", requireOrigin(Origin.main), express.json(), proxyKevel); | |||
| router.all("/pimg/*", requireOrigin(Origin.main), proxyKevel); | |||
| router.all("/pong/*", requireOrigin(Origin.main), express.json(), proxyPong); | |||
Check failure
Code scanning / CodeQL
Missing rate limiting High
LeoMcA
requested changes
Oct 11, 2023
libs/pong/pong2.js
Outdated
| }, | ||
| }; | ||
| }); | ||
| const decisionRes = await Promise.all(requests); |
There was a problem hiding this comment.
Do we want all placements to fail if just one does, might Promise.allSettled be more appropriate here?
fiji-flo
commented
Oct 12, 2023
LeoMcA
approved these changes
Oct 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Remove unused Carbon fallback and support BSA.
How did you test this change?
Staging.