chore(telemetry): send geo_iso with pings #9909
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
caugner
force-pushed
the
send-country-code-in-pings
branch
from
d9fb40f to
c01f353
Compare
LeoMcA
approved these changes
Nov 6, 2023
There was a problem hiding this comment.
one small copy nit, otherwise looks good - tested locally and forwards the country_iso value from rumba (ZZ in this case): https://debug-ping-preview.firebaseapp.com/pings/mdn-dev/9e5d5ee1-da33-454b-aeca-ff0fce65c75b#L40
Co-authored-by: Leo McArdle <[email protected]>
caugner
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Problem
Currently, we only send the user's country name to Glean, but names change (c.f. Czechia) and may have inconsistent writings.
Solution
Also send the user's country code to Glean.
How did you test this change?
TBD