Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove redirectIO #18

Merged
merged 4 commits into from
Feb 21, 2022
Merged

remove redirectIO #18

merged 4 commits into from
Feb 21, 2022

Conversation

akleb
Copy link
Contributor

@akleb akleb commented Oct 7, 2021 •
edited by sseraj
Loading

Purpose

Remove redirectIO and move it to baseclasses with extra utility. mdolab/baseclasses#69

Type of change

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (non-backwards-compatible fix or feature)
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no API changes)
  • Documentation update
  • Maintenance update
  • Other (please describe)

Testing

Checklist

  • I have run flake8 and black to make sure the code adheres to PEP-8 and is consistently formatted
  • I have run unit and regression tests which pass locally with my changes
  • I have added new tests that prove my fix is effective or that my feature works
  • I have added necessary documentation

@akleb akleb requested a review from a team as a code owner October 7, 2021 15:56
@akleb akleb requested review from ewu63 and joanibal October 7, 2021 15:56
@ewu63 ewu63 merged commit c5861ec into mdolab:master Feb 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marcomangano marcomangano marcomangano approved these changes

@ewu63 ewu63 ewu63 approved these changes

@joanibal joanibal Awaiting requested review from joanibal joanibal was automatically assigned from mdolab/multipoint_maintainers

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@akleb @ewu63 @marcomangano