-
Notifications
You must be signed in to change notification settings - Fork 109
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updating minimum dependency requirements #388
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #388 +/- ##
=======================================
Coverage 74.10% 74.10%
=======================================
Files 22 22
Lines 3290 3290
=======================================
Hits 2438 2438
Misses 852 852 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just updating numpy and scipy for now is fine with me
@marcomangano just to formally respond and for future reference. I am in favor of SPEC 0 for our codebase. We have been discussing this in https://github.com/mdolab/docker/issues/241 and should continue there. |
Bumped the minor version since the minimum version update could potentially be a breaking change? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. Just to clarify, do you want to wait for the docker PR? Nervermind, no need to wait.
Purpose
Issues like #387 show that the current minimum dependency versions are out of date - even considering our own stencil of supported dependencies.
I updated the minimum numpy and scipy versions to our
stable
set of dependencies.However, I think we should also update the
mdolab-baseclasses
version and, more importantly, the minimum python version. The code itself is not changing but this would create issues for the users who are still relying on older python environments.@ewu63 suggests to adopt the NEP29 (or the more recent SPEC 0 policy) to avoid this issue, but I think at that point we should extend this to the whole organization packages.
I want to hear @eirikurj take as well as he has been working on a way to map these dependencies over time.
Expected time until merged
1 day if we are ok with only updating numpy and scipy
Type of change
Testing
Checklist
flake8
andblack
to make sure the Python code adheres to PEP-8 and is consistently formattedfprettify
or C/C++ code withclang-format
as applicable