Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating minimum dependency requirements #388

Merged
merged 13 commits into from
Apr 25, 2024
Merged

Conversation

marcomangano
Copy link
Contributor

@marcomangano marcomangano commented Feb 27, 2024

Purpose

Issues like #387 show that the current minimum dependency versions are out of date - even considering our own stencil of supported dependencies.
I updated the minimum numpy and scipy versions to our stable set of dependencies.

However, I think we should also update the mdolab-baseclasses version and, more importantly, the minimum python version. The code itself is not changing but this would create issues for the users who are still relying on older python environments.

@ewu63 suggests to adopt the NEP29 (or the more recent SPEC 0 policy) to avoid this issue, but I think at that point we should extend this to the whole organization packages.
I want to hear @eirikurj take as well as he has been working on a way to map these dependencies over time.

Expected time until merged

1 day if we are ok with only updating numpy and scipy

Type of change

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (non-backwards-compatible fix or feature)
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no API changes)
  • Documentation update
  • Maintenance update
  • Other (please describe)

Testing

Checklist

  • I have run flake8 and black to make sure the Python code adheres to PEP-8 and is consistently formatted
  • I have formatted the Fortran code with fprettify or C/C++ code with clang-format as applicable
  • I have run unit and regression tests which pass locally with my changes
  • I have added new tests that prove my fix is effective or that my feature works
  • I have added necessary documentation

@marcomangano marcomangano requested a review from a team as a code owner February 27, 2024 19:29
Copy link

codecov bot commented Feb 27, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 74.10%. Comparing base (01d5111) to head (c932ec9).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #388   +/-   ##
=======================================
  Coverage   74.10%   74.10%           
=======================================
  Files          22       22           
  Lines        3290     3290           
=======================================
  Hits         2438     2438           
  Misses        852      852           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

sseraj
sseraj previously approved these changes Feb 28, 2024
Copy link
Collaborator

@sseraj sseraj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just updating numpy and scipy for now is fine with me

@eirikurj
Copy link
Contributor

@marcomangano just to formally respond and for future reference. I am in favor of SPEC 0 for our codebase. We have been discussing this in https://github.com/mdolab/docker/issues/241 and should continue there.

@marcomangano
Copy link
Contributor Author

Bumped the minor version since the minimum version update could potentially be a breaking change?

@marcomangano
Copy link
Contributor Author

@sseraj @lamkina @eirikurj can you check this out to see if got the right package versions? We should merge ASAP and make a new release.

Copy link
Collaborator

@sseraj sseraj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good

Copy link
Contributor

@eirikurj eirikurj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Just to clarify, do you want to wait for the docker PR? Nervermind, no need to wait.

@eirikurj eirikurj merged commit a988404 into main Apr 25, 2024
12 checks passed
@eirikurj eirikurj deleted the marcomangano-patch-1 branch April 25, 2024 10:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants