Merge pull request gregmalcolm#170 from kjc/with_context_manager

Python 3 test_finding_lines2() assert passes as-is
mdomenjoud · Feb 13, 2018 · ff7e4ab · ff7e4ab
2 parents 602498b + 875f163
commit ff7e4ab
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 7 deletions.
diff --git a/python2/koans/about_with_statements.py b/python2/koans/about_with_statements.py
@@ -91,12 +91,13 @@ def test_counting_lines2(self):
     # ------------------------------------------------------------------
 
     def find_line2(self, file_name):
-        # Rewrite find_line using the Context Manager.
-        pass
+        # Using the context manager self.FileContextManager, rewrite this
+        # function to return the first line containing the letter 'e'.
+        return None
 
     def test_finding_lines2(self):
-        self.assertEqual(__, self.find_line2("example_file.txt"))
         self.assertNotEqual(None, self.find_line2("example_file.txt"))
+        self.assertEqual('test\n', self.find_line2("example_file.txt"))
 
     # ------------------------------------------------------------------
 

diff --git a/python3/koans/about_with_statements.py b/python3/koans/about_with_statements.py
@@ -90,12 +90,13 @@ def test_counting_lines2(self):
     # ------------------------------------------------------------------
 
     def find_line2(self, file_name):
-        # Rewrite find_line using the Context Manager.
-        pass
+        # Using the context manager self.FileContextManager, rewrite this
+        # function to return the first line containing the letter 'e'.
+        return None
 
     def test_finding_lines2(self):
-        self.assertEqual(__, self.find_line2("example_file.txt"))
-        self.assertNotEqual(__, self.find_line2("example_file.txt"))
+        self.assertNotEqual(None, self.find_line2("example_file.txt"))
+        self.assertEqual('test\n', self.find_line2("example_file.txt"))
 
     # ------------------------------------------------------------------