Merge pull request #87 from petemounce/clarity

Change the annotation name to reflect the data
mdsol · Jul 14, 2016 · e573030 · e573030
2 parents bda17ec + 5377f4b
commit e573030
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 4 deletions.
diff --git a/src/Medidata.ZipkinTracer.Core/SpanTracer.cs b/src/Medidata.ZipkinTracer.Core/SpanTracer.cs
@@ -39,7 +39,7 @@ public virtual Span ReceiveServerSpan(string spanName, string traceId, string pa
 
             newSpan.Annotations.Add(annotation);
 
-            AddBinaryAnnotation("http.uri", requestUri.AbsolutePath, newSpan, serviceEndpoint);
+            AddBinaryAnnotation("http.path", requestUri.AbsolutePath, newSpan, serviceEndpoint);
 
             return newSpan;
         }
@@ -80,7 +80,7 @@ public virtual Span SendClientSpan(string spanName, string traceId, string paren
             };
 
             newSpan.Annotations.Add(annotation);
-            AddBinaryAnnotation("http.uri", remoteUri.AbsolutePath, newSpan, serviceEndpoint);
+            AddBinaryAnnotation("http.path", remoteUri.AbsolutePath, newSpan, serviceEndpoint);
             AddBinaryAnnotation("sa", "1", newSpan, zipkinEndpoint.GetRemoteEndpoint(remoteUri, clientServiceName));
 
             return newSpan;

diff --git a/tests/Medidata.ZipkinTracer.Core.Test/SpanTracerTests.cs b/tests/Medidata.ZipkinTracer.Core.Test/SpanTracerTests.cs
@@ -100,7 +100,7 @@ public void ReceiveServerSpan()
 
             Assert.AreEqual(1, binaryAnnotations.Count());
 
-            AssertBinaryAnnotations(binaryAnnotations, "http.uri", serverUri.AbsolutePath);
+            AssertBinaryAnnotations(binaryAnnotations, "http.path", serverUri.AbsolutePath);
         }
 
         [TestMethod]
@@ -235,7 +235,7 @@ public void SendClientSpan()
             var binaryAnnotations = resultSpan.GetAnnotationsByType<BinaryAnnotation>();
 
             Assert.AreEqual(2, binaryAnnotations.Count());
-            AssertBinaryAnnotations(binaryAnnotations, "http.uri", serverUri.AbsolutePath);
+            AssertBinaryAnnotations(binaryAnnotations, "http.path", serverUri.AbsolutePath);
             AssertBinaryAnnotations(binaryAnnotations, "sa", "1");
 
             var endpoint = binaryAnnotations.ToArray()[1].Host as Endpoint;