Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert from anyhow to thiserror #17

Merged
merged 2 commits into from
Jun 3, 2024
Merged

Conversation

masongup-mdsol
Copy link
Member

Improve the error reporting by converting from anyhow to thiserror. Anyhow is a convenience crate meant for applications which obscures error details in order to make it easier for application developers who are not concerned about error details at the current time to get code out. Crates should expose error details clearly and in a strongly-typed way to consuming applications so that those applications are able to either use those details to react properly or ignore them, as the application business needs dictate. Thiserror is a crate designed for this purpose, so it is a better fit for this crate.

Copy link
Contributor

@ykitamura-mdsol ykitamura-mdsol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me 👍

@masongup-mdsol
Copy link
Member Author

Thanks! I'm planning to also update some of the docs in another PR before bumping the version and tagging. The published docs look pretty bare-bones.

@masongup-mdsol masongup-mdsol merged commit 3114291 into main Jun 3, 2024
2 checks passed
@ykitamura-mdsol ykitamura-mdsol deleted the errors-to-thiserror branch June 3, 2024 21:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants