Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deterministic cfbs #54

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Deterministic cfbs #54

wants to merge 3 commits into from

Conversation

sftse
Copy link

@sftse sftse commented Apr 18, 2024

I need a way to reliably generate deterministic cfb files. It seems it suffices to be able to override the timestamps.

mdsteele
mdsteele reviewed May 4, 2024
View reviewed changes
Copy link
Owner

@mdsteele mdsteele left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, these seem like good methods to add.

src/lib.rs Outdated Show resolved Hide resolved
src/lib.rs Show resolved Hide resolved
src/lib.rs Outdated Show resolved Hide resolved
Cargo.toml Outdated Show resolved Hide resolved
@sftse
Copy link
Author

sftse commented May 21, 2024

This is a bit beside the point of this PR, but I happen to notice that the timestamps coming from Entry::created and Entry::modified are nonsensical on streams since those timestamps are all zeroes. Should these functions perhaps return Option<SystemTime>?

@sftse sftse requested a review from mdsteele May 21, 2024 10:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mdsteele mdsteele Awaiting requested review from mdsteele

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sftse @mdsteele