Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make directory processing more permissive #56

Closed
wants to merge 1 commit into from

Conversation

shamilsan
Copy link

Sometimes we are to open CFB files with corrupted directory structure.

In this PR we skip weird dir entries (in permissive mode) instead of returning an error.

Mostly inspired by compoundfiles.entities

@shamilsan
Copy link
Author

@mdsteele Could you please take a look?

@mdsteele
Copy link
Owner

mdsteele commented Sep 5, 2024

Thanks. Could you add some unit tests for this?

@shamilsan
Copy link
Author

Thanks. Could you add some unit tests for this?

Ok, I'll try my best a little bit later.

@shamilsan shamilsan closed this Oct 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants