Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a CPAL playback test. #19

Merged
merged 1 commit into from
Apr 8, 2024
Merged

Add a CPAL playback test. #19

merged 1 commit into from
Apr 8, 2024

Conversation

mdwn
Copy link
Owner

@mdwn mdwn commented Apr 8, 2024

A test has been added to the CPAL playback function. It's difficult to test this in its entirety due to its dependence on actual audio hardware, but we can at least verify that the output callback does what we expect. Some light refactoring was done as part of this.

A test has been added to the CPAL playback function. It's difficult to
test this in its entirety due to its dependence on actual audio hardware,
but we can at least verify that the output callback does what we expect.
Some light refactoring was done as part of this.
@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 12.50000% with 14 lines in your changes are missing coverage. Please review.

Project coverage is 53.72%. Comparing base (dbd23cf) to head (edb6778).

Files Patch % Lines
src/audio/cpal.rs 12.50% 14 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #19      +/-   ##
==========================================
+ Coverage   52.53%   53.72%   +1.19%     
==========================================
  Files          20       20              
  Lines        1047     1048       +1     
==========================================
+ Hits          550      563      +13     
+ Misses        497      485      -12     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mdwn mdwn merged commit 5869d56 into main Apr 8, 2024
6 checks passed
@mdwn mdwn linked an issue Apr 11, 2024 that may be closed by this pull request
@mdwn mdwn deleted the add-cpal-playback-test branch June 19, 2024 02:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Increase code coverage
2 participants