Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Downsize 721CM and 721M #127

Merged
merged 1 commit into from
Apr 1, 2024
Merged

Downsize 721CM and 721M #127

merged 1 commit into from
Apr 1, 2024

Conversation

channing-magiceden
Copy link
Contributor

@channing-magiceden channing-magiceden commented Mar 30, 2024

  • downsize the two contracts by removing
    • updateStage - we never used it and can be done via setStages
    • setBaseURIPermanent - no usage and can be done by transfer ownership to null
Before After
ERC721M 16.501 15.346
ERC721CM 20.944 19.748
  • Some refactors will be done to further downsize the core contracts

@channing-magiceden channing-magiceden marked this pull request as ready for review March 30, 2024 00:19
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.33%. Comparing base (196f485) to head (6c744ea).

❗ Current head 6c744ea differs from pull request most recent head b08ad6e. Consider uploading reports for the commit b08ad6e to get more accurate results

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #127      +/-   ##
==========================================
- Coverage   91.91%   91.33%   -0.59%     
==========================================
  Files          13       13              
  Lines         507      473      -34     
  Branches      144      132      -12     
==========================================
- Hits          466      432      -34     
  Misses         41       41              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@channing-magiceden channing-magiceden merged commit a1d65e4 into main Apr 1, 2024
2 checks passed
@channing-magiceden channing-magiceden deleted the channing/downsize branch April 1, 2024 17:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants