Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add magicdrop-types package and set up CI #155

Merged
merged 10 commits into from
Oct 1, 2024
Merged

Add magicdrop-types package and set up CI #155

merged 10 commits into from
Oct 1, 2024

Conversation

channing-magiceden
Copy link
Contributor

@channing-magiceden channing-magiceden commented Sep 30, 2024 •
edited
Loading

  • Created magicdrop-types package and move interfaces there
  • Update IERC721, IERC721MInitializable, and IERC1155 for ME launchpad
  • Clean and set up CI

Testing npm published packages:

tenthirtyone
tenthirtyone approved these changes Oct 1, 2024
View reviewed changes
Copy link

@tenthirtyone tenthirtyone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice size savings 👍

@nothing0012 nothing0012 merged commit b7cd554 into me-foundation:main Oct 1, 2024
2 checks passed
Amin8087
Amin8087 reviewed Oct 3, 2024
View reviewed changes
Copy link

@Amin8087 Amin8087 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amin

@Amin8087
Copy link

Amin8087 commented Oct 3, 2024

Amin

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Amin8087 Amin8087 Amin8087 left review comments

@nothing0012 nothing0012 nothing0012 approved these changes

@tenthirtyone tenthirtyone tenthirtyone approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@channing-magiceden @Amin8087 @tenthirtyone @nothing0012