Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: shallowclone option is not working #51

Merged
merged 1 commit into from
Jan 8, 2024

Conversation

MrLuje
Copy link
Contributor

@MrLuje MrLuje commented Jan 4, 2024

Fixes #50

Copy link
Collaborator

@eitsupi eitsupi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for working on this!
Could you bump the patch version here?

@eitsupi eitsupi requested a review from andreiborisov January 4, 2024 08:14
Copy link
Collaborator

@eitsupi eitsupi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The test failure is unrelated this PR.
(We need to fix the tests because the Dev Container CLI was updated a long time ago to run tests as a non-root user.)

@eitsupi
Copy link
Collaborator

eitsupi commented Jan 4, 2024

The test fixes #52

@andreiborisov
Copy link
Member

@MrLuje please, rebase on the latest commit from main to fix the tests 🙂

@MrLuje
Copy link
Contributor Author

MrLuje commented Jan 5, 2024

@andreiborisov rebase done, thanks

@eitsupi
Copy link
Collaborator

eitsupi commented Jan 7, 2024

@MrLuje Could you squash the commits into one and rewrite the commit comment using 🐛 emoji instead of "fix: "?
Like this: cc1e0db

If it's difficult, we'll recreate the commits.

@MrLuje
Copy link
Contributor Author

MrLuje commented Jan 8, 2024

@eitsupi done

@eitsupi
Copy link
Collaborator

eitsupi commented Jan 8, 2024

/ff

Copy link
Contributor

github-actions bot commented Jan 8, 2024

⏩ Merged the MrLuje-patch-1 branch as a fast-forward into the main branch

@github-actions github-actions bot merged commit b25a587 into meaningful-ooo:main Jan 8, 2024
11 checks passed
@eitsupi
Copy link
Collaborator

eitsupi commented Jan 8, 2024

Thanks @MrLuje, the new version has been published!

@MrLuje MrLuje deleted the MrLuje-patch-1 branch January 8, 2024 12:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

Shallow clone flag not working
3 participants