MBS-8971: Small fixes

classes/migrationhelper.php

@@ -17,8 +17,7 @@
 namespace mod_learningmap;
 
 /**
- * This class provides helper functions for migration from older learningmaps being stored in the intro field
- * to the new column 'svgcode'.
+ * This class provides helper functions for migration from learningmaps being stored in the intro field to the new column svgcode.
  *
  * @package    mod_learningmap
  * @copyright  2024 ISB Bayern
@@ -73,9 +72,9 @@ public static function move_files_to_background_filearea(int $instanceid) {
      * Checks if the given learningmap instance has a SVG code stored in the 'svgcode' column.
      *
      * @param int $instanceid The id of the learningmap instance.
-     * @return boolean
+     * @return bool
      */
-    public static function is_version_without_svgcode(int $instanceid) {
+    public static function is_version_without_svgcode(int $instanceid): bool {
         global $DB;
         $entry = $DB->get_record('learningmap', ['id' => $instanceid]);
         return empty($entry->svgcode);
@@ -84,7 +83,7 @@ public static function is_version_without_svgcode(int $instanceid) {
     /**
      * Update one learningmap instance to have the SVG code stored in the 'svgcode' column.
      *
-     * @param integer $instanceid The id of the learningmap instance. If empty, all learningmaps will be updated.
+     * @param int $instanceid The id of the learningmap instance. If empty, all learningmaps will be updated.
      * @return void
      */
     public static function update_learningmaps_to_use_svgcode(int $instanceid = 0) {

tests/generator/lib.php

@@ -18,7 +18,7 @@
  * mod_learningmap data generator
  *
  * @package     mod_learningmap
- * @copyright 2021-2024, ISB Bayern
+ * @copyright   2021-2024, ISB Bayern
  * @author      Stefan Hanauska <[email protected]>
  * @license     http://www.gnu.org/copyleft/gpl.html GNU GPL v3 or later
  */
@@ -36,8 +36,10 @@ public function create_instance($record = null, array $options = null): stdClass
 
         $record = (array)$record + [
             'name' => 'test map',
-            'intro' => file_get_contents($CFG->dirroot . '/mod/learningmap/tests/generator/test.svg'),
-            'introformat' => 1,
+            'intro' => 'test intro',
+            'introformat' => 0,
+            'svgcode' => file_get_contents($CFG->dirroot . '/mod/learningmap/tests/generator/test.svg'),
+            'showmaponcoursepage' => 1,
             'placestore' => file_get_contents($CFG->dirroot . '/mod/learningmap/tests/generator/test.json'),
             'completiontype' => 2,
         ];

tests/mod_learningmap_activitymanager_test.php

@@ -27,7 +27,7 @@
  * Unit test for mod_learningmap
  *
  * @package     mod_learningmap
- * @copyright 2021-2024, ISB Bayern
+ * @copyright   2021-2024, ISB Bayern
  * @author      Stefan Hanauska <[email protected]>
  * @license     http://www.gnu.org/copyleft/gpl.html GNU GPL v3 or later
  * @group      mod_learningmap

tests/mod_learningmap_generation_test.php

@@ -20,7 +20,7 @@
  * Unit test for mod_learningmap
  *
  * @package     mod_learningmap
- * @copyright 2021-2024, ISB Bayern
+ * @copyright   2021-2024, ISB Bayern
  * @author      Stefan Hanauska <[email protected]>
  * @license     http://www.gnu.org/copyleft/gpl.html GNU GPL v3 or later
  * @group      mod_learningmap