Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MBS-8800: Add suffix for default completion #95

Merged
merged 1 commit into from
Feb 16, 2024

Conversation

sh-csg
Copy link
Contributor

@sh-csg sh-csg commented Feb 13, 2024

No description provided.

@sh-csg sh-csg self-assigned this Feb 13, 2024
@sh-csg sh-csg force-pushed the MBS-8800-Add-suffix-for-default-completion branch 3 times, most recently from 147097a to f7103b4 Compare February 16, 2024 09:09
Copy link
Member

@PhMemmel PhMemmel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A suggestion and a question :)

mod_form.php Outdated Show resolved Hide resolved
mod_form.php Show resolved Hide resolved
@sh-csg sh-csg force-pushed the MBS-8800-Add-suffix-for-default-completion branch from f7103b4 to 8484c7c Compare February 16, 2024 11:06
Copy link
Member

@PhMemmel PhMemmel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Nice work keeping backwards compatibility in an elegant and easily maintainable way.

@PhMemmel PhMemmel merged commit a0fbf44 into master Feb 16, 2024
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants