Skip to content
This repository has been archived by the owner on Mar 29, 2023. It is now read-only.

fix: disable_by_keypress can't become false. #32

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

fix: disable_by_keypress can't become false. #32

wants to merge 4 commits into from

Conversation

nameldk
Copy link

@nameldk nameldk commented Mar 28, 2023

No description provided.

@mechatroner
Copy link
Owner

Hello! I appreciate your intention to fix this, but perhaps it is OK that disable_by_keypress can never become false for a particular page. It is hard for me to come up with a scenario when re-enabling it would be undesirable, but still, I want to play safe in this case. I also currently don't have enough time to fix it in case something would go wrong.

@nameldk
fix: tabs permission
e9d8ba1
@nameldk
fix: dict word may end with \r\n.
a542afa 
web page word will search from dict and use the result to match user_vocabulary.
@nameldk
fix: use span instead of customtag with a -.
3b4b6d7
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nameldk @mechatroner