Hotfix/issue_183/memory leakage #210
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@chandeldivyam this is partially solving the issue, there is still memory leak on xcap and screencapture libs and my memory increases forever, let's focus on scap switch now |
|
@louis030195 Have we done anything previously? Something where I could start from or we need to start it from scratch? |
|
Also, we should ideally first create a metric / benchmark so that we can measure the current state. And when we release changes how it is moving. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
frame_queue is not being consumed anywhere right now. It grew to a very large size which was increasing the memory extremely high. The maximum memory must be dependent on the monitor resolution as the frame size would differ.
This led to a tremendous increase in memory utilization.
We have capped the max queue size and also stopped pushing to the queue. If we want to consume it later, we can again start pushing.
After the changed, tried running
.\target\release\screenpipe.exe --ocr-engine windows-native --disable-audiofor constantly 1 hour, the memory spike never occurred. I think this could potentially solve #183Tested it exhaustively on Windows. Need to test it on mac + linux.
How did you test?