Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(compose): make grafana provisioning mount be read/write #83

Merged
merged 1 commit into from
Aug 25, 2023
Merged

feat(compose): make grafana provisioning mount be read/write #83

merged 1 commit into from
Aug 25, 2023

Conversation

mrjones-plip
Copy link
Contributor

@mrjones-plip mrjones-plip commented Aug 15, 2023 •
edited
Loading

This PR is needed so users who are extending watchdog can do something like this in an additional YAML compose file:

services:
  grafana:
    volumes:
      - ./extra-sql-dashboard.json:/etc/grafana/provisioning/dashboards/CHT/cht_admin_extra_sql.json:ro

If not, no extra files can be mounted into /etc/grafana/provisioning because it's read only.

@mrjones-plip mrjones-plip changed the title Make Grafana provisioning mount be readable Make Grafana provisioning mount be read/write Aug 15, 2023
@mrjones-plip mrjones-plip changed the title Make Grafana provisioning mount be read/write feat(server): Make Grafana provisioning mount be read/write Aug 15, 2023
@mrjones-plip mrjones-plip changed the title feat(server): Make Grafana provisioning mount be read/write feat(grafana): Make Grafana provisioning mount be read/write Aug 15, 2023
@mrjones-plip mrjones-plip changed the title feat(grafana): Make Grafana provisioning mount be read/write feat(compose): Make Grafana provisioning mount be read/write Aug 15, 2023
@mrjones-plip
Copy link
Contributor Author

lol - I couldn't decide on the title 😅

@mrjones-plip mrjones-plip changed the title feat(compose): Make Grafana provisioning mount be read/write feat(compose): make grafana provisioning mount be read/write Aug 15, 2023
jkuester
jkuester approved these changes Aug 25, 2023
View reviewed changes
Copy link
Collaborator

@jkuester jkuester left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mrjones-plip mrjones-plip merged commit 287f713 into main Aug 25, 2023
3 of 9 checks passed
@mrjones-plip mrjones-plip deleted the grafana-provisioning-readable-mount branch August 25, 2023 16:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jkuester jkuester jkuester approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mrjones-plip @jkuester