Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

disable add to cart when no variant #124

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

disable add to cart when no variant #124

wants to merge 1 commit into from

Commits on May 21, 2023

  1. disable add to cart when no variant 

    The add to cart button doesn't do anything when there is no variant selected which makes sense because you need to pick a size when buying a sweatshirt. However the button looks like it's an active button and looks like it's being clicked. This change makes the UI reflect the underlying reality of the button not doing anything.

Note that I'm brand new to Medusa and e-commerce in general, I won't be offended if I'm told I'm off base. For example, perhaps there are products that don't have variants, what happens then? Given that the seed data has variants this provides for a better first time experience but perhaps isn't fully correct.
    @burbma
    burbma authored May 21, 2023
    Configuration menu
    Copy the full SHA
    530af04 View commit details
    Browse the repository at this point in the history