CV2-5082 add logic to suppress a callback event to check-api when explicitly requested #440
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…licitly requested
skyemeedan
approved these changes
Aug 26, 2024
Co-authored-by: Skye Bender-deMoll <[email protected]>
Co-authored-by: Skye Bender-deMoll <[email protected]>
|
Code Climate has analyzed commit 0ab5c50 and detected 0 issues on this pull request. The test coverage on the diff in this pull request is 76.9% (50% is the threshold). This pull request will bring the total coverage in the repository to 79.7% (0.0% change). View more on Code Climate. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In some cases we want to index items to alegre, but we don't care about completing a round trip request back to check-api. This adds an additional parameter that, in conjunction with meedan/check-api#1996 will allow for the ability to suppress a response to Check API.
Reference: CV2-5082
How has this been tested?
Not yet tested - will likely require its own unit test, for now lets see if it breaks anything
Have you considered secure coding practices when writing this code?
Nothing in particular of concern here!